-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rd-refine change missing; fixing no-open-gop doing nothing #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've used VSCode and edited those 2 files, and made sure the json format was correct and all parameters are linked to the definitions in the bottom part of file. However due to I've mainly worked with x265.exe instead of libx265, some parameters are missing in libx265 and I cannot gurantee they actually will work (some parameter may get deleted or the definitions needs to be modified if libx265 v3.5 persists not recognizing) Software is not my profession and I wish I could compile and test the changes myself. Someone needs to compile and check in software to see if the parameters are applied correctly. Changes also happened in x264 parameters, they have been separated with color profiles (4:2:0 and 4:4:4) thus creates more versions, just 1 version needs to be tested for them.
libx265.json worked prefectly in both value application and encoding (I stopped encoding half way because it's too slow). libx264.json has some issues, I'll provide images and this change is the fix
Missspelled to 'offest', didn't catch this error previously
…st-scenecut, hist-threshold are currently missing. Deblock formatting was fixed (default CLI was deblock +-int:+-int, but realized it was actually a comma instead of colon)
…st-scenecut, hist-threshold are currently missing. Deblock formatting was fixed (default CLI was deblock +-int:+-int, but realized it was actually a comma instead of colon)
…array (no formatting errors found in VSCode); Changed default value for --weightp to {value: true} in property array which matches with default true in x265, this doesn't encoding but only reduces confustion
…p Coldwar; disabled mcstf because it still disables multithreading so far (huge performance issue;disabled hist-scenecut due to test reveled stability issue, especially at 12bit)
…--cbqpoffs and --crqpoffs by 2
…pen-gop toggle failure
…pen-gop toggle failure
…pen-gop toggle failure (2)
The "no-open-gop" failing problem could be one occurence addressed in #64. |
I have added the changes manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of pull request #141:
Some rd-refine disablement was missing: It does not work & prompts with warning when rd<4, change was made from Update x265 params #141 by switching parameter value to 0 (disable) for all presets.
Unsuccessful at applying no-open-gop: It turns out the
"no-open-gop": "1"
doesn't work, I have changed all occurences to"open-gop": "0"
Notes:
Open GOP (Group of pictures) is a video stream structure standard that allows further compression by allowing reference-based compression to work beyond GOP border, which adds compression slightly in trade-off on some compatibility and increases error propagation distance.
There are short GOP and long GOP encoding choices: